| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Amul Sul <sulamul(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, Neha Sharma <neha(dot)sharma(at)enterprisedb(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [CLOBBER_CACHE]Server crashed with segfault 11 while executing clusterdb |
| Date: | 2021-04-19 06:55:08 |
| Message-ID: | YH0pTLbyl9uIp19j@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Apr 09, 2021 at 06:45:45PM -0400, Alvaro Herrera wrote:
> We forgot this patch earlier in the commitfest. Do people think we
> should still get it in on this cycle? I'm +1 on that, since it's a
> safety feature poised to prevent more bugs than it's likely to
> introduce.
No objections from here to do that now even after feature freeze. I
also wonder, while looking at that, why you don't just remove the last
call within src/backend/catalog/heap.c. This way, nobody is tempted
to use RelationOpenSmgr() anymore, and it could just be removed from
rel.h.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2021-04-19 07:02:47 | Re: Table refer leak in logical replication |
| Previous Message | Amul Sul | 2021-04-19 06:24:00 | Re: Remove redundant variable from transformCreateStmt |