| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Amul Sul <sulamul(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Noah Misch <noah(at)leadboat(dot)com>, Neha Sharma <neha(dot)sharma(at)enterprisedb(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [CLOBBER_CACHE]Server crashed with segfault 11 while executing clusterdb |
| Date: | 2021-04-09 22:45:45 |
| Message-ID: | 20210409224545.GA32253@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Mar-25, Amul Sul wrote:
> Ok, in the attached patch, I have added the inline function to rel.h, and for
> that, I end up including smgr.h to rel.h. I tried to replace all rel->rd_smgr
> by RelationGetSmgr() function and removed the RelationOpenSmgr() call from
> the nearby to it which I don't think needed at all.
We forgot this patch earlier in the commitfest. Do people think we
should still get it in on this cycle? I'm +1 on that, since it's a
safety feature poised to prevent more bugs than it's likely to
introduce.
--
Álvaro Herrera Valdivia, Chile
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2021-04-09 23:02:38 | Re: pgsql: Add libpq pipeline mode support to pgbench |
| Previous Message | Tom Lane | 2021-04-09 22:40:27 | PANIC: wrong buffer passed to visibilitymap_clear |