| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Refactor SSL test framework to support multiple TLS libraries |
| Date: | 2021-03-31 01:01:45 |
| Message-ID: | YGPJ+VRUMgQiGsdB@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 30, 2021 at 07:14:55PM -0300, Alvaro Herrera wrote:
> On 2021-Mar-30, Daniel Gustafsson wrote:
>> This double concatenation could be a single concat, or just use scalar value
>> interpolation in the string to make it even more readable. As it isn't using
>> the same line broken pattern of the others the concat looks a bit weird as a
>> result.
>
> +1 for using a single scalar.
Agreed. I posted things this way to make a lookup at the diffs easier
for the eye, but that was not intended for the final patch.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2021-03-31 01:09:43 | Re: Use consistent terminology for tablesync slots. |
| Previous Message | Mark Dilger | 2021-03-31 00:59:08 | Re: multi-install PostgresNode fails with older postgres versions |