Re: Refactor SSL test framework to support multiple TLS libraries

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Refactor SSL test framework to support multiple TLS libraries
Date: 2021-03-30 22:14:55
Message-ID: 20210330221455.GA321@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-Mar-30, Daniel Gustafsson wrote:

> +$node->connect_ok($common_connstr . " " . "user=ssltestuser",
>
> This double concatenation could be a single concat, or just use scalar value
> interpolation in the string to make it even more readable. As it isn't using
> the same line broken pattern of the others the concat looks a bit weird as a
> result.

+1 for using a single scalar.

--
Álvaro Herrera Valdivia, Chile

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Dilger 2021-03-30 22:17:26 Re: multi-install PostgresNode fails with older postgres versions
Previous Message Tom Lane 2021-03-30 22:13:45 Re: making update/delete of inheritance trees scale better