| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Subject: | Re: pgsql: Remove support for SSL compression |
| Date: | 2021-03-09 03:26:15 |
| Message-ID: | YEbq15JKJwIX+S6m@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Tue, Mar 09, 2021 at 02:18:52AM +0000, Michael Paquier wrote:
> Remove support for SSL compression
>
> PostgreSQL disabled compression as of e3bdb2d and the documentation
> recommends against using it since. Additionally, SSL compression has
> been disabled in OpenSSL since version 1.1.0, and was disabled in many
> distributions long before that. The most recent TLS version, TLSv1.3,
> disallows compression at the protocol level.
(Adding Daniel in CC)
So, this is breaking a test case in crake where an upgrade from 9.3 is
done with a FDW server using this option that gets restored:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2021-03-09%2002%3A32%3A29
pg_restore: while PROCESSING TOC:
pg_restore: from TOC entry 1541; 1417 55431 SERVER testserver1
buildfarm
pg_restore: error: could not execute query: ERROR: invalid option
"sslcompression"
It looks like it is not that much a good idea to define it as a debug
option after all. So I guess that the attached would fix the failure,
where FDW servers can still pass down the parameter at will for
backward-compatibility, and where libpq keeps ignoring its value. Any
thoughts?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| sslcompression-fix.patch | text/x-diff | 2.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-03-09 05:23:16 | pgsql: Add support for more progress reporting in COPY |
| Previous Message | Michael Paquier | 2021-03-09 02:18:52 | pgsql: Remove support for SSL compression |