Re: some pointless HeapTupleHeaderIndicatesMovedPartitions calls

On Sat, Feb 20, 2021 at 12:25:58PM -0300, Álvaro Herrera wrote:
> On 2021-Feb-20, Michael Paquier wrote:
>> Hearing nothing, I have looked at this stuff and the simplification
>> makes sense. Any comments?
>
> No further comments ... I think the patch is simple enough. Thanks for
> looking -- I'll get it pushed on Monday or so.

Sounds good to me.

>> I can see that ItemPointerSetMovedPartitions() in itemptr.h is not
>> used in the code. Could it be better to change the comment in
>> htup_details.h to mention HeapTupleHeaderSetMovedPartitions instead?
>> Perhaps not worth bothering, just noticed this on the way.
>
> Hmm. Alternatively, maybe it'd make sense to change
> HeapTupleHeaderSetMovedPartition to use ItemPointerSetMovedPartitions
> instead of doing ItemPointerSet directly. But that looks mostly
> pointless, since the extensibility aspect of this interface has been
> superseded by table AM work. I agree we should just remove the macro
> and update the comment as you suggest.

Thanks. So you will do this change in the same commit, right?
--
Michael