Re: some pointless HeapTupleHeaderIndicatesMovedPartitions calls

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Subject: Re: some pointless HeapTupleHeaderIndicatesMovedPartitions calls
Date: 2021-02-20 12:58:04
Message-ID: YDEHXEKurDw2/wvK@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Feb 13, 2021 at 10:49:26AM +0900, Michael Paquier wrote:
> So that's this patch: https://commitfest.postgresql.org/32/2941/.
> Alvaro is most likely going to take care of that, so let's wait for
> him.

Hearing nothing, I have looked at this stuff and the simplification
makes sense. Any comments?

I can see that ItemPointerSetMovedPartitions() in itemptr.h is not
used in the code. Could it be better to change the comment in
htup_details.h to mention HeapTupleHeaderSetMovedPartitions instead?
Perhaps not worth bothering, just noticed this on the way.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Josef Šimánek 2021-02-20 13:17:30 Re: Improvements and additions to COPY progress reporting
Previous Message Markus Wanner 2021-02-20 12:48:49 Re: [PATCH] Present all committed transaction to the output plugin