| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Adjust interaction of CREATEROLE with role properties. |
| Date: | 2023-01-27 00:24:37 |
| Message-ID: | Y9MZxVrCoutVbMCM@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Thu, Jan 26, 2023 at 12:31:06PM -0600, Justin Pryzby wrote:
> On Thu, Jan 26, 2023 at 09:46:07AM -0500, Andrew Dunstan wrote:
>> Would it be worth adding a check right at the end of the schedule that
>> makes sure there are no such roles left?
>
> Yes, because the alternative is to have cirrus run "installcheck"
> twice..
Agreed about doing something like that, with a new SQL script perhaps?
We can rely on -DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS here, and
I'd like to think that nobody creates such role names or they would
see failures with the new query. I can also be a sign that such
instances should be cleaned up to allow more repeatability with some
tests, actually..
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-01-27 01:22:19 | pgsql: Fix behavior with pg_restore -l and compressed dumps |
| Previous Message | Tom Lane | 2023-01-26 22:09:21 | pgsql: Improve TimestampDifferenceMilliseconds to cope with overflow sa |