Re: pgsql: Adjust interaction of CREATEROLE with role properties.

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Adjust interaction of CREATEROLE with role properties.
Date: 2023-01-26 18:31:06
Message-ID: 20230126183106.GS22427@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Jan 26, 2023 at 09:46:07AM -0500, Andrew Dunstan wrote:
>
> On 2023-01-26 Th 08:00, Robert Haas wrote:
> > On Thu, Jan 26, 2023 at 6:58 AM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> >> On 2023-Jan-24, Robert Haas wrote:
> >>
> >>> Adjust interaction of CREATEROLE with role properties.
> >> This commit broke the ability to run 'make installcheck' repeatedly,
> >> because it fails to drop role regress_role_limited_admin.
> > Argh, sorry. I keep making that mistake.
>
>
> Would it be worth adding a check right at the end of the schedule that
> makes sure there are no such roles left?

Yes, because the alternative is to have cirrus run "installcheck"
twice..

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2023-01-26 22:09:21 pgsql: Improve TimestampDifferenceMilliseconds to cope with overflow sa
Previous Message Tom Lane 2023-01-26 17:51:07 pgsql: Code review for commit 05a7be935.