| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Victor Spirin <v(dot)spirin(at)postgrespro(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: psql tab-complete |
| Date: | 2022-12-22 02:25:03 |
| Message-ID: | Y6O//9UXalcHVbEe@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 21, 2022 at 05:56:05PM -0500, Tom Lane wrote:
> Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
>> Since I really want to be able to use VA_ARGS_NARGS() elsewhere,
>
> +1, that'd be handy.
>
>> ... Assuming those switches actually work as claimed, I see
>> two choices: commit this hack with a comment reminding us to clean it
>> up later, or drop 2015.
>
> As long as we can hide the messiness inside a macro definition,
> I'd vote for the former.
Agreed, even if it is worth noting that all the buildfarm members
with MSVC use 2017 or newer.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-12-22 02:27:46 | Re: Add LSN along with offset to error messages reported for WAL file read/write/validate header failures |
| Previous Message | Thomas Munro | 2022-12-22 02:04:04 | Re: Direct I/O |