Re: psql tab-complete

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Victor Spirin <v(dot)spirin(at)postgrespro(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: psql tab-complete
Date: 2022-12-22 05:36:58
Message-ID: CA+hUKGJUEgoYaLum7zwV+kUtP9OSSDyO-NT2=ZSk89890hMU2A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Dec 22, 2022 at 3:25 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Wed, Dec 21, 2022 at 05:56:05PM -0500, Tom Lane wrote:
> > Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> >> Since I really want to be able to use VA_ARGS_NARGS() elsewhere,
> >
> > +1, that'd be handy.
> >
> >> ... Assuming those switches actually work as claimed, I see
> >> two choices: commit this hack with a comment reminding us to clean it
> >> up later, or drop 2015.
> >
> > As long as we can hide the messiness inside a macro definition,
> > I'd vote for the former.
>
> Agreed, even if it is worth noting that all the buildfarm members
> with MSVC use 2017 or newer.

Thanks. Pushed.

PS is it a mistake that we still mention SDK 8.1 in the docs?

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2022-12-22 05:40:57 Re: Rework of collation code, extensibility
Previous Message Michael Paquier 2022-12-22 05:04:48 Re: Simplifications for error messages related to compression