| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Checksum errors in pg_stat_database |
| Date: | 2022-12-12 01:08:08 |
| Message-ID: | Y5Z++JmUJvTWmiuK@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Dec 11, 2022 at 04:51:49PM -0800, Andres Freund wrote:
> Why were you thinking of tracking it separately from PgStat_StatTabEntry?
We only know the relfilenode when loading the page on a checksum
failure, not its parent relation, and there are things like physical
base backups where we would not know them anyway because we may not be
connected to a database. Or perhaps it would be possible to link
table entries with their relfilenodes using some tweaks in the stat
APIs? I am sure that you know the business in this area better than I
do currently :)
> I think there's a good argument for starting to track some stats based on the
> relfilenode, rather the oid, because it'd allow us to track e.g. the number of
> writes for a relation too (we don't have the oid when writing out
> buffers). But that's a relatively large change...
Yeah. I was thinking among the lines of sync requests and sync
failures, as well.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Oliver Yang | 2022-12-12 01:38:31 | Why does L&Y Blink Tree need lock coupling? |
| Previous Message | Andres Freund | 2022-12-12 00:51:49 | Re: Checksum errors in pg_stat_database |