Re: New docs chapter on Transaction Management and related changes

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>, Robert Treat <rob(at)xzilla(dot)net>, Erik Rijkers <er(at)xs4all(dot)nl>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: New docs chapter on Transaction Management and related changes
Date: 2022-12-01 15:48:04
Message-ID: Y4jMtPHYgIFxh+O5@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 30, 2022 at 12:31:55PM -0500, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > I find it a bit shocking to have had it backpatched, even to 15 -- a
> > whole chapter in the documentation? I don't see why it wouldn't be
> > treated like any other "major feature" patch, which we only consider for
> > the development branch. Also, this is a first cut -- presumably we'll
> > want to copy-edit it before it becomes released material.
>
> I think that last point is fairly convincing. I've not read the
> new material, but I didn't get further than the first line of
> the new chapter file before noting a copy-and-paste error:
>
> --- /dev/null
> +++ b/doc/src/sgml/xact.sgml
> @@ -0,0 +1,205 @@
> +<!-- doc/src/sgml/mvcc.sgml -->

Fixed in master.

> That doesn't leave me with a warm feeling that it's ready to ship.
> I too vote for reverting it out of the released branches.

Patch reverted in all back branches. I was hoping to get support for
more aggressive backpatches of docs, but obviously failed. I should
have been clearer about my intent to backpatch, and will have to
consider these issues in future doc backpatches.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

Embrace your flaws. They make you human, rather than perfect,
which you will never be.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2022-12-01 16:13:01 Re: Temporary tables versus wraparound... again
Previous Message Peter Eisentraut 2022-12-01 15:18:21 pg_upgrade: Make testing different transfer modes easier