| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix comment in SnapBuildFindSnapshot |
| Date: | 2022-11-28 07:46:44 |
| Message-ID: | Y4RnZAD9h+0hw1WM@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 28, 2022 at 11:13:23AM +0900, Masahiko Sawada wrote:
> We have the following comment in SnapBuildFindSnapshot():
>
> * c) transition from FULL_SNAPSHOT to CONSISTENT.
> *
> * In FULL_SNAPSHOT state (see d) ), and this xl_running_xacts'
>
> It mentions "(state d) )", which seems like a typo of "(state d)", but
> there is no "state d" in the first place. Reading the discussion of
> the commit 955a684e040 that introduced this comment, this was a
> comment for an old version patch[1]. So I think we can remove this
> part.
Hm, yes, that seems right. There are three "c) states" in these
paragraphs, they are incremental steps. Will apply if there are no
objections.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ian Lawrence Barwick | 2022-11-28 07:55:43 | Re: Understanding, testing and improving our Windows filesystem code |
| Previous Message | Michael Paquier | 2022-11-28 07:40:52 | Re: Remove a unused argument from qual_is_pushdown_safe |