Re: Remove a unused argument from qual_is_pushdown_safe

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Remove a unused argument from qual_is_pushdown_safe
Date: 2022-11-28 07:40:52
Message-ID: Y4RmBNzVXvTSDmIG@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 28, 2022 at 11:54:45AM +0900, Michael Paquier wrote:
> On Fri, Nov 25, 2022 at 04:05:13PM +0800, Richard Guo wrote:
>> I wonder if we need to revise the comment atop qual_is_pushdown_safe()
>> too which says
>>
>> * rinfo is a restriction clause applying to the given subquery (whose RTE
>> * has index rti in the parent query).
>>
>> since there is no 'given subquery' after we remove it from the params.

I was thinking about this point, and it seems to me that we could just
do s/the given subquery/a subquery/. But perhaps you have a different
view on the matter?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-11-28 07:46:44 Re: Fix comment in SnapBuildFindSnapshot
Previous Message Michail Nikolaev 2022-11-28 07:19:31 Re: Slow standby snapshot