| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Anton A(dot) Melnikov" <aamelnikov(at)inbox(dot)ru> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Maxim Orlov <orlovmg(at)gmail(dot)com> |
| Subject: | Re: [BUG] Logical replica crash if there was an error in a function. |
| Date: | 2022-10-12 05:24:29 |
| Message-ID: | Y0ZPjR12Idz6Vq8s@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Oct 09, 2022 at 12:24:23PM +0300, Anton A. Melnikov wrote:
> On the other hand, function_parse_error_transpose() tries to get
> the original query text (INSERT INTO test VALUES ('1') in our case) from
> the ActivePortal to clarify the location of the error.
> But in the logrep worker there is no way to restore original query text
> from the logrep message. There is only 'zipped' query equivalent to the original.
> So any function_parse_error_transpose() call seems to be useless
> in the logrep worker.
Yeah, the query string is not available in this context, but it surely
looks wrong to me to assume that something as low-level as
function_parse_error_transpose() needs to be updated for the sake of a
logical worker, while we have other areas that would expect a portal
to be set up.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-10-12 05:26:38 | Re: [PATCH] Clarify the comments about varlena header encoding |
| Previous Message | Michael Paquier | 2022-10-12 05:20:43 | Re: Fix gin index cost estimation |