| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, "Ryo Matsumura (Fujitsu)" <matsumura(dot)ryo(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: DDL result is lost by CREATE DATABASE with WAL_LOG strategy |
| Date: | 2023-02-21 06:13:10 |
| Message-ID: | Y/Rg9o5ijRsxijLT@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Feb 20, 2023 at 04:43:22PM -0800, Nathan Bossart wrote:
> On Mon, Feb 20, 2023 at 05:02:01PM +0900, Michael Paquier wrote:
>> On Fri, Feb 17, 2023 at 02:35:30PM -0800, Nathan Bossart wrote:
>>> I'm happy to move this new test to wherever folks think it should go. I'll
>>> look around to see if I can find a better place, too.
>>
>> I think that src/test/recovery/ is the best fit, because this stresses
>> a code path for WAL replay on pg_class for the template db. The name
>> is not specific enough, though, why not just using something like
>> 0NN_create_database.pl?
>
> Okay. I've renamed the test file as suggested in v3.
The test enforces a checkpoint after the table creation on the
template, so what about testing it also without a checkpoint, like the
extended version attached? I have tweaked a few things in the test,
while on it.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| create_db_fix_v4.patch | text/x-diff | 3.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2023-02-21 07:11:06 | Re: [Proposal] Add foreign-server health checks infrastructure |
| Previous Message | Nathan Bossart | 2023-02-21 05:49:48 | Re: WAL Insertion Lock Improvements |