| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alexander Korotkov <akorotkov(at)postgresql(dot)org> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Multirange datatypes |
| Date: | 2020-12-21 07:34:09 |
| Message-ID: | X+BP8XE0UpIB6Yvh@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Hi Alexander,
On Sun, Dec 20, 2020 at 04:21:16AM +0000, Alexander Korotkov wrote:
> Multirange datatypes
>
> Multiranges are basically sorted arrays of non-overlapping ranges with
> set-theoretic operations defined over them.
This commit is creating a compilation warning on Windows:
multirangetypes.c(1033): warning C4715: 'multirange_constructor0' :
not all control paths return a value
See for example woodlouse:
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=woodlouse&dt=2020-12-21%2001%3A42%3A28&stg=make
Looking at the code, it is obvious that the compiler cannot understand
that this should always return. Please find attached a suggestion of
patch.
Thanks,
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| multirange-warning.patch | text/x-diff | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2020-12-21 11:26:29 | pgsql: Fix compiler warning in multirange_constructor0() |
| Previous Message | Sandeep Thakkar | 2020-12-21 03:21:30 | Re: pgsql: Multirange datatypes |