| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Alexander Korotkov <akorotkov(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Multirange datatypes |
| Date: | 2020-12-21 11:31:44 |
| Message-ID: | CAPpHfdvO7xF2VGzjSOc---ruxGoAAxjVqHTtXW_2yLTSs=g1MA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Hi, Michael!
On Mon, Dec 21, 2020 at 10:34 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Sun, Dec 20, 2020 at 04:21:16AM +0000, Alexander Korotkov wrote:
> > Multirange datatypes
> >
> > Multiranges are basically sorted arrays of non-overlapping ranges with
> > set-theoretic operations defined over them.
>
> This commit is creating a compilation warning on Windows:
> multirangetypes.c(1033): warning C4715: 'multirange_constructor0' :
> not all control paths return a value
>
> See for example woodlouse:
> https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=woodlouse&dt=2020-12-21%2001%3A42%3A28&stg=make
>
> Looking at the code, it is obvious that the compiler cannot understand
> that this should always return. Please find attached a suggestion of
> patch.
Thank you for catching this! Pushed.
------
Regards,
Alexander Korotkov
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2020-12-21 11:39:30 | Re: pgsql: Multirange datatypes |
| Previous Message | Alexander Korotkov | 2020-12-21 11:26:29 | pgsql: Fix compiler warning in multirange_constructor0() |