| From: | Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Stephen Frost" <sfrost(at)snowman(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Preliminary results for proposed new pgindent implementation |
| Date: | 2017-06-16 21:05:27 |
| Message-ID: | VI1PR03MB1199C38E4391905BBDDA25D3F2C10@VI1PR03MB1199.eurprd03.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017-06-16 20:11, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
>> On 2017-06-16 13:44:30 -0400, Bruce Momjian wrote:
>>> Yes, it is all about <80 column output. The current pgindent does
>>> everything possible to accomplish that --- the question is whether we
>>> want uglier code to do it.
>
>> For me personally the misindentation is way uglier than a too long line.
>
> I assume though that Piotr wants an option to preserve that behavior.
> I'm happy to write up a patch for bsdindent that adds a switch
> controlling this, but is there any rhyme or reason to the way its
> switches are named?
I don't want to preserve the current behavior at all, but I might need
to add an option for choosing one or the other if users of FreeBSD
indent protest.
I don't have a good name for it. The best I can do is -lpl ("-lp long
lines too"). Can I see the patch?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Euler Taveira | 2017-06-16 21:43:54 | Re: Restrictions of logical replication |
| Previous Message | Bruce Momjian | 2017-06-16 20:47:18 | Re: Broken hint bits (freeze) |