RE: Remove duplicate table scan in logical apply worker and code refactoring

From: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Subject: RE: Remove duplicate table scan in logical apply worker and code refactoring
Date: 2024-08-01 01:59:11
Message-ID: TYCPR01MB56935ACDCFF46795AEECB908F5B22@TYCPR01MB5693.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dear Hou,

> Thanks for reviewing the patch, and your understanding is correct.
>
> Here is the updated patch 0001. I removed the comments as suggested by Amit.
>
> Since 0002 patch is only refactoring the code and I need some time to review
> the comments for it, I will hold it until the 0001 is committed.

Thanks for updating the patch. I did a performance testing with v2-0001.

Before: 15.553 [s]
After: 7.593 [s]

I used the attached script for setting up. I used almost the same setting and synchronous
replication is used.

[machine]
CPU(s): 120
Model name: Intel(R) Xeon(R) CPU E7-4890 v2 @ 2.80GHz
Core(s) per socket: 15
Socket(s): 4

Best regards,
Hayato Kuroda
FUJITSU LIMITED

Attachment Content-Type Size
test.sh application/octet-stream 1.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2024-08-01 02:01:07 Re: On disable_cost
Previous Message Melanie Plageman 2024-08-01 01:12:15 Re: Add LSN <-> time conversion functionality