Re: Remove duplicate table scan in logical apply worker and code refactoring

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
Cc: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove duplicate table scan in logical apply worker and code refactoring
Date: 2024-08-01 08:55:50
Message-ID: CAA4eK1J-K5szWN_M5P7dkj2K_OGS9WkYzMY8oqmnhdCwSAkuWg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 1, 2024 at 7:29 AM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> > Thanks for reviewing the patch, and your understanding is correct.
> >
> > Here is the updated patch 0001. I removed the comments as suggested by Amit.
> >
> > Since 0002 patch is only refactoring the code and I need some time to review
> > the comments for it, I will hold it until the 0001 is committed.
>
> Thanks for updating the patch. I did a performance testing with v2-0001.
>
> Before: 15.553 [s]
> After: 7.593 [s]
>

Thanks for the testing. I have pushed the patch.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Hayato Kuroda (Fujitsu) 2024-08-01 08:56:13 RE: Conflict detection and logging in logical replication
Previous Message Richard Guo 2024-08-01 08:44:22 Query results vary depending on the plan cache mode used