| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Peter Smith' <smithpb2250(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, "Takamichi Osumi (Fujitsu)" <osumi(dot)takamichi(at)fujitsu(dot)com> |
| Subject: | RE: PGdoc: add missing ID attribute to create_subscription.sgml |
| Date: | 2023-03-27 09:21:01 |
| Message-ID: | TYAPR01MB5866C8D269A6CB585855C394F58B9@TYAPR01MB5866.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Peter,
Thank you for reviewing! PSA new version.
> doc/src/sgml/logical-replication.sgml
>
> 1.
> I am not sure your convention to only give the link to the FIRST
> reference on a page is good in all case. Maybe that rule is OK for
> multiple references all in the same sub-section but when they are in
> different sub-sections (even on one page) I think it would be better
> to include the extra links.
Sounds better for readability.
> 1a.
> For example, Section 33.3 (Row Filter) refers to
> "publish_via_partition_root" lots of times across multiple subsections
> – So it is not convenient to have to scroll around looking in
> different sections for the topmost reference which has the link.
Added only two links because almost lines were in the same sub-section(Examples).
Did it match with your expectation?
> 1b.
> Also in Section 33.3 (Row Filter), there are a couple of places you
> could link to "publish" parameter on this page.
IIUC there was only one point to add the link, but added.
Also, I have added further links for "FOR ALL TABLES" and "FOR TABLES IN SCHEMA" clauses.
> 2.
> I thought was a missing link in 31.7.1 (Architecture/Initial Snapshot)
> which could've linked to the "publish" parameter.
>
Added.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Add-XML-ID-attributes-to-create_subscription.sgml.patch | application/octet-stream | 15.5 KB |
| v3-0002-Add-XML-ID-attributes-to-create_publication.sgml.patch | application/octet-stream | 14.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2023-03-27 09:42:34 | Re: awkward cancellation of parallel queries on standby. |
| Previous Message | Hayato Kuroda (Fujitsu) | 2023-03-27 09:17:50 | RE: PGdoc: add missing ID attribute to create_subscription.sgml |