| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, "Takamichi Osumi (Fujitsu)" <osumi(dot)takamichi(at)fujitsu(dot)com> |
| Subject: | Re: PGdoc: add missing ID attribute to create_subscription.sgml |
| Date: | 2023-03-27 06:58:25 |
| Message-ID: | CAHut+Pvzo6=KKLqMR6-mAQdM+j_dse0eUreGmrFouL7gbLbv2w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Here are review comments for v2-0002
======
doc/src/sgml/logical-replication.sgml
1.
I am not sure your convention to only give the link to the FIRST
reference on a page is good in all case. Maybe that rule is OK for
multiple references all in the same sub-section but when they are in
different sub-sections (even on one page) I think it would be better
to include the extra links.
1a.
For example, Section 33.3 (Row Filter) refers to
"publish_via_partition_root" lots of times across multiple subsections
– So it is not convenient to have to scroll around looking in
different sections for the topmost reference which has the link.
1b.
Also in Section 33.3 (Row Filter), there are a couple of places you
could link to "publish" parameter on this page.
~~~
2.
I thought was a missing link in 31.7.1 (Architecture/Initial Snapshot)
which could've linked to the "publish" parameter.
------
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-03-27 07:23:38 | Re: Generate pg_stat_get_xact*() functions with Macros |
| Previous Message | Peter Smith | 2023-03-27 06:56:53 | Re: PGdoc: add missing ID attribute to create_subscription.sgml |