patch: Add missing descriptions for rmgr APIs

From: "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: patch: Add missing descriptions for rmgr APIs
Date: 2022-08-29 03:18:14
Message-ID: TYAPR01MB58665F20F412EDF27B0759CFF5769@TYAPR01MB5866.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi hackers,

While reading codes related with logical decoding,
I thought that following comment in rmgrlist.h is not consistent.

> /* symbol name, textual name, redo, desc, identify, startup, cleanup */

This comment describes a set of APIs that the resource manager should have, but functions for {mask, decode} are missed here.

Did we have any reasons for that? I thought it might be not friendly, so I attached a patch.

Best Regards,
Hayato Kuroda
FUJITSU LIMITED

Attachment Content-Type Size
0001-add-a-missing-comment.patch application/octet-stream 1.0 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2022-08-29 04:13:52 Re: standby promotion can create unreadable WAL
Previous Message Amit Kapila 2022-08-29 03:10:29 Re: Handle infinite recursion in logical replication setup