| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: patch: Add missing descriptions for rmgr APIs |
| Date: | 2022-08-29 12:11:00 |
| Message-ID: | CAA4eK1KxjhVG35MmBPg3ggkMr1nz21ewr5c_DbVcMmOCzBSKMg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 29, 2022 at 8:48 AM kuroda(dot)hayato(at)fujitsu(dot)com
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Hi hackers,
>
> While reading codes related with logical decoding,
> I thought that following comment in rmgrlist.h is not consistent.
>
> > /* symbol name, textual name, redo, desc, identify, startup, cleanup */
>
> This comment describes a set of APIs that the resource manager should have, but functions for {mask, decode} are missed here.
>
Your observation seems correct to me but you have not updated the
comment for the mask. Is there a reason for the same?
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Anton Voloshin | 2022-08-29 12:27:18 | Re: Make #else/#endif comments more consistent |
| Previous Message | Amit Kapila | 2022-08-29 11:51:44 | Re: Handle infinite recursion in logical replication setup |