| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Shubham Khanna' <khannashubham1197(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Adding a '--two-phase' option to 'pg_createsubscriber' utility. |
| Date: | 2024-12-12 02:43:50 |
| Message-ID: | TYAPR01MB56926557E26E3B2FCF91EF77F53F2@TYAPR01MB5692.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Shubham,
> Thank you for pointing this out and for suggesting the changes. I
> agree with your approach.
> Also, I found a mistake in getopt_long and fixed it in this version of
> the patch.
> The attached patch contains the suggested changes.
Thanks for updating the patch. I think the patch looks mostly OK.
Regarding the test code - I think we should directly refer the pg_subscription catalog,
and confirm that subtwophase is 'p'. IIUC, we can wait until
all subscriptions. Subtwophasestate are 'e', by using poll_query_until() and [1].
[1]: SELECT count(1) = 0 FROM pg_subscription WHERE subtwophasestate NOT IN ('e');
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2024-12-12 02:44:42 | Re: Wrong results with right-semi-joins |
| Previous Message | Peter Smith | 2024-12-12 02:32:19 | Re: pg_createsubscriber TAP test wrapping makes command options hard to read. |