| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Shubham Khanna' <khannashubham1197(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Rajendra Kumar Dangwal <dangwalrajendra888(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "euler(at)eulerto(dot)com" <euler(at)eulerto(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | RE: Pgoutput not capturing the generated columns |
| Date: | 2024-10-28 03:17:23 |
| Message-ID: | TYAPR01MB56921B9E85AFD90631682A4DF54A2@TYAPR01MB5692.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Shubham,
Thanks for updating the patch! I resumed reviewing the patch set.
Here are only cosmetic comments as my rehabilitation.
01. getPublications()
I feel we could follow the notation like getSubscriptions(), because number of
parameters became larger. How do you feel like attached?
02. fetch_remote_table_info()
```
"SELECT DISTINCT"
- " (CASE WHEN (array_length(gpt.attrs, 1) = c.relnatts)"
- " THEN NULL ELSE gpt.attrs END)"
+ " (gpt.attrs)"
```
I think no need to separate lines and add bracket. How about like below?
```
"SELECT DISTINCT gpt.attrs"
```
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| refactor_dump.txt | text/plain | 2.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stepan Neretin | 2024-10-28 03:44:59 | Re: Assertion failure when autovacuum drops orphan temp indexes. |
| Previous Message | Zhijie Hou (Fujitsu) | 2024-10-28 03:06:34 | RE: Conflict detection for update_deleted in logical replication |