| From: | Shubham Khanna <khannashubham1197(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Rajendra Kumar Dangwal <dangwalrajendra888(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "euler(at)eulerto(dot)com" <euler(at)eulerto(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: Pgoutput not capturing the generated columns |
| Date: | 2024-10-28 13:10:51 |
| Message-ID: | CAHv8RjK+ps-jDLqPahUy=pX9yn9mL4k3jw35GxBEcZBF=mnbOg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 28, 2024 at 8:47 AM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear Shubham,
>
> Thanks for updating the patch! I resumed reviewing the patch set.
> Here are only cosmetic comments as my rehabilitation.
>
> 01. getPublications()
>
> I feel we could follow the notation like getSubscriptions(), because number of
> parameters became larger. How do you feel like attached?
>
I will handle this comment in a later set of patches.
> 02. fetch_remote_table_info()
>
> ```
> "SELECT DISTINCT"
> - " (CASE WHEN (array_length(gpt.attrs, 1) = c.relnatts)"
> - " THEN NULL ELSE gpt.attrs END)"
> + " (gpt.attrs)"
> ```
>
> I think no need to separate lines and add bracket. How about like below?
>
> ```
> "SELECT DISTINCT gpt.attrs"
> ```
>
Fixed this.
The v44 version patches attached at [1] have the changes for the same.
[1] - https://www.postgresql.org/message-id/CAHv8RjLvr8ZxX-1TcaxrZns1nwgrVUTO_2jhDdOPys0WgrDyKQ%40mail.gmail.com
Thanks and Regards,
Shubham Khanna.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2024-10-28 13:19:11 | Re: Alias of VALUES RTE in explain plan |
| Previous Message | Shubham Khanna | 2024-10-28 13:07:26 | Re: Pgoutput not capturing the generated columns |