Re: [CFReview] Red-Black Tree

From: Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Teodor Sigaev <teodor(at)sigaev(dot)ru>, Mark Cave-Ayland <mark(dot)cave-ayland(at)siriusit(dot)co(dot)uk>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [CFReview] Red-Black Tree
Date: 2010-02-03 16:43:53
Message-ID: Pine.LNX.4.64.1002031941360.16860@sn.sai.msu.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 3 Feb 2010, Robert Haas wrote:

> On Wed, Feb 3, 2010 at 8:48 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> 2010/2/3 Teodor Sigaev <teodor(at)sigaev(dot)ru>:
>>>> Can you rename RED and BLACK to RBRED and RBBLACK?
>>>
>>> Yes, of course, done.
>>>
>>> Any objections to commit?
>>
>> I would like to see point #2 of the following email addressed before
>> commit.  As things stand, it is not clear (at least to me) whether
>> this is a win.
>>
>> http://archives.postgresql.org/pgsql-hackers/2010-01/msg02552.php
>
> Specifically, on this web page:
>
> http://www.sai.msu.su/~megera/wiki/2009-04-03
>
> There is a section that begins with this line of text:
>
> Repeat test with 100,000 identical records varying array length (len).
>
> That test shows rbtree being a third slower than HEAD. But there's
> not enough information on that web page to replicate that test, so
> it's hard to speculate on what may be going wrong. I don't think we
> should commit this until we understand that.

Robert, Mark described the test he did
http://archives.postgresql.org/pgsql-hackers/2010-01/msg02927.php

Regards,
Oleg
_____________________________________________________________
Oleg Bartunov, Research Scientist, Head of AstroNet (www.astronet.ru)
Sternberg Astronomical Institute, Moscow University, Russia
Internet: oleg(at)sai(dot)msu(dot)su, http://www.sai.msu.su/~megera/
phone: +007(495)939-16-83, +007(495)939-23-83

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-02-03 16:45:44 CommitFest Status Summary - 2010-02-03
Previous Message Merlin Moncure 2010-02-03 16:41:42 Re: Review of Writeable CTE Patch