Re: pg_restore ignore error patch

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: pg_restore ignore error patch
Date: 2004-04-20 07:36:18
Message-ID: Pine.LNX.4.58.0404200932151.6454@sablons.cri.ensmp.fr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


> > > I looked over the patch and it seems to continue on pg_restore errors by
> > > default. That isn't good. By default, any error should make it exit
> > > loudly.
> >
> > I'm not sure of that. pg_dump is really designed and tested for the
> > case of text dump to a psql script, and if there is an error in the psql
> > [...]
>
> Oh, OK, so make it behave like pg_dump's text output piped into psql.

It is really easy to add an option to allow user change the 'ignore'
behavior, and make pg_restore exit loudly if it is desired.

Maybe it should be proposed just for backwards compatibility?

--
Fabien Coelho - coelho(at)cri(dot)ensmp(dot)fr

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Peter Eisentraut 2004-04-20 10:05:30 Re: CSV patch applied
Previous Message Alvaro Herrera 2004-04-20 05:32:55 Re: Basic subtransaction facility