Re: pg_restore ignore error patch

Fabien COELHO wrote:
>
> > > > I looked over the patch and it seems to continue on pg_restore errors by
> > > > default. That isn't good. By default, any error should make it exit
> > > > loudly.
> > >
> > > I'm not sure of that. pg_dump is really designed and tested for the
> > > case of text dump to a psql script, and if there is an error in the psql
> > > [...]
> >
> > Oh, OK, so make it behave like pg_dump's text output piped into psql.
>
> It is really easy to add an option to allow user change the 'ignore'
> behavior, and make pg_restore exit loudly if it is desired.
>
> Maybe it should be proposed just for backwards compatibility?

Let's see if anyone asks for it. Unless they do, we will just enable it
by default. As long as we exit with a non-zero status on error, just
like psql, I think we are OK.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073