From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
Subject: | Re: rename/unlink handling for Win32 |
Date: | 2003-04-20 16:16:46 |
Message-ID: | Pine.LNX.4.44.0304201757210.2891-100000@peter.localdomain |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian writes:
> The following patch loops over rename/unlink every 1/10th of second,
> printing a warning message after 1 second, and printing a completion
> message if a warning message was printed.
I don't like that; it seems arbitrary. How does the need to wait relate
to other factors, such as the system load?
About the code: The code you placed into pg_config_manual.h must go into
some other header file, probably a separate one that parallels the .c
file. Also, I would prefer if the C files in src/port were named after
the function they implement, so rename.c.
It might also be cleaner if we changed the code to use remove() instead of
unlink(), since the ISO C standard uses the former whereas the latter is
Unix-ish.
--
Peter Eisentraut peter_e(at)gmx(dot)net
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Sullivan | 2003-04-20 16:55:33 | Re: default locale considered harmful? (was Re: Using index for "like 'ABC%'" type query) |
Previous Message | Peter Eisentraut | 2003-04-20 16:16:20 | Re: default locale considered harmful? (was Re: [GENERAL] |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2003-04-21 14:35:20 | Re: [HACKERS] rename/unlink handling for Win32 |
Previous Message | Bruce Momjian | 2003-04-20 02:47:38 | Re: rename/unlink handling for Win32 |