Re: [HACKERS] rename/unlink handling for Win32

[ Thread moved to patches, where I should have posted it at first.]

Peter Eisentraut wrote:
> Bruce Momjian writes:
>
> > The following patch loops over rename/unlink every 1/10th of second,
> > printing a warning message after 1 second, and printing a completion
> > message if a warning message was printed.
>
> I don't like that; it seems arbitrary. How does the need to wait relate
> to other factors, such as the system load?

I wasn't clear --- it basically tries 10 times, not necessarily over one
second, and it doesn't print "1 second" or anything.

The values only control whether it prints anything to the logs --- it
will continue looping until it succeeds. Do you see any other solution?

> About the code: The code you placed into pg_config_manual.h must go into
> some other header file, probably a separate one that parallels the .c
> file. Also, I would prefer if the C files in src/port were named after

You want dirmod.h for two prototypes? If I do that, then am I including
that from pg_config_manual.h or somewhere else?

What we could do is to create a port.h file and pull the other /port
prototypes like fseeko() into that file. Is that what you want?

> the function they implement, so rename.c.

But we have rename and unlink in there. I don't think we want two
files, do we? They do almost the same thing. That's why I called it
dirmod.c.

> It might also be cleaner if we changed the code to use remove() instead of
> unlink(), since the ISO C standard uses the former whereas the latter is
> Unix-ish.

I didn't want to get into that for this patch. If someone wants to
rename them across the source code, they are welcome to do that, though
unlink() seems more common than remove() to me.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073