| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Vadim Mikheev <vadim4o(at)email(dot)com>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql/src (Makefile.global.in) |
| Date: | 2000-11-20 16:52:38 |
| Message-ID: | Pine.LNX.4.21.0011201742510.1090-100000@peter.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Tom Lane writes:
> vadim(at)postgresql(dot)org writes:
>
> *** 145,150 ****
> --- 145,152 ----
> ifeq ($(GCC), yes)
> CFLAGS += -Wall -Wmissing-prototypes -Wmissing-declarations
> endif
> +
> + CFLAGS += -DXLOG
(Should be CPPFLAGS anyway.)
>
> CXX = @CXX@
> GXX = @GXX@
>
> Ick. Couldn't we do this by #define XLOG in config.h.in, instead?
> CFLAGS are horribly vulnerable to people overriding them with
> make options.
>
> I do recall that when I last tried to build with WAL, my attempt
> to add #define XLOG to config.h failed --- but that indicates poor
> coding practices elsewhere. It *should* work to add or remove a
> feature symbol in config.h.
Surely checking #ifdef XLOG before including postgres.h won't help. Fix
coming in right now.
--
Peter Eisentraut peter_e(at)gmx(dot)net http://yi.org/peter-e/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | petere | 2000-11-20 16:52:54 | pgsql/src (Makefile.global.in) |
| Previous Message | petere | 2000-11-20 16:47:32 | pgsql/src/backend/storage/buffer (bufmgr.c localbuf.c) |