Re: pgsql/src (Makefile.global.in)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Vadim Mikheev <vadim4o(at)email(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql/src (Makefile.global.in)
Date: 2000-11-20 05:33:12
Message-ID: 23635.974698392@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

vadim(at)postgresql(dot)org writes:

*** 145,150 ****
--- 145,152 ----
ifeq ($(GCC), yes)
CFLAGS += -Wall -Wmissing-prototypes -Wmissing-declarations
endif
+
+ CFLAGS += -DXLOG

CXX = @CXX@
GXX = @GXX@

Ick. Couldn't we do this by #define XLOG in config.h.in, instead?
CFLAGS are horribly vulnerable to people overriding them with
make options.

I do recall that when I last tried to build with WAL, my attempt
to add #define XLOG to config.h failed --- but that indicates poor
coding practices elsewhere. It *should* work to add or remove a
feature symbol in config.h.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Lockhart 2000-11-20 07:04:10 Re: [COMMITTERS] pgsql/src/backend/utils/adt (cash.c)
Previous Message vadim 2000-11-20 05:18:40 pgsql/src/include/catalog (catversion.h)