Re: How to submit Tsearch V2 ?

From: Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
To: Teodor Sigaev <teodor(at)sigaev(dot)ru>
Cc: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: How to submit Tsearch V2 ?
Date: 2003-07-05 10:53:49
Message-ID: Pine.GSO.4.56.0307051437510.7788@ra.sai.msu.su
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Chris,

would be the right solution to make tsearch V2 to be fully incompatible
with old tsearch (so both version could live in one database) and
release tsearch v2 in separate directory. This way require some additional
work but would not confuse people. As a bonus, people could start playing
with new tsearch V2 very easy.

We need "the right wordings" in README.tsearch of old tsearch to
warn people that old tsearch is deprecated and will be obsoleted in the next
release of PostgreSQL.

Teodor, how it'd be difficult ?

Oleg

On Fri, 4 Jul 2003, Teodor Sigaev wrote:

> Well, I doubt what is right way.
>
> tsearch V2 use new names, new function new feature and hasn't compatibility with
> old one.
>
> 1 tsearch2 and tsearch directory in contrib. tsearch marked as deprecated and
> will be removed for 7.5
> 2 V2 places in contrib as tsearch, old tsearch will be at our site.
>
>
> It seems to me that second way is correcter way. Two version of tsearch is
> surplus...
>
> What do people think about it?
>
>
> Christopher Kings-Lynne wrote:
> >>So, for upgrading tsearch to V2 you need to do following:
> >>1 rename columns or typecast for type txtidx to tsvector, query_txt to tsquery
> >>2 rename function txt2txtidx to to_tsvector, ( may be to strip(to_tsvector()),
> >> now tsvector has information for ranking ), trigger 'tsearch' isn't changed
> >>3 operator class (in create index command) gist_txtidx_ops to gist_tsvector_ops
> >>4 In queries: operator ## to @@ to_tsquery() and remove mquery_txt typecast
> >>5 If your locale of pgsql differ from 'C', execute before first query
> >> select set_curcfg('default');
> >>
> >>That's all. So upgrade from v1 to v2 isn't difficult.
> >
> >
> > And you expect thousands of users to do this? I don't know about that...
> >
> > I can barely handle it myself, and I was looking forward to a Postgres
> > upgrade for a change where I didn't have to edit the dump :(
> >
> > Chris
> >
>
>

Regards,
Oleg
_____________________________________________________________
Oleg Bartunov, sci.researcher, hostmaster of AstroNet,
Sternberg Astronomical Institute, Moscow University (Russia)
Internet: oleg(at)sai(dot)msu(dot)su, http://www.sai.msu.su/~megera/
phone: +007(095)939-16-83, +007(095)939-23-83

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dan Langille 2003-07-05 11:16:23 Re: Are we backwards on the sign of timezones?
Previous Message Hans-Jürgen Schönig 2003-07-05 05:48:53 PostgreSQL 7.3.3 and Intel C compiler