Re: [HACKERS] psql compile problems

On Wed, 16 Feb 2000, Bruce Momjian wrote:

> > I just looked into the code and found that the file pgsql/common.c includes
> > interfaces/libpq/c.h instead of include/c.h. I changed the CFLAGS setting in
> > the Makefile to append -I$(LIBPQDIR) instead of insert it and it compiles
> > fine.
> >
> > BTW the file common.c includes c.h twice, directly and via common.h.
>
> I have cleaned up include file use in psql. It now uses the standard
> postgres.h includes and does not use redundant includes as much.

Actually, the point of including c.h (plus postgres_ext.h) rather than
postgres.h was to not have access to the backend internal stuff, so as to
keep the separation clean. But it doesn't really matter to me. Also, on my
system at least, there were no redundant includes. I actually went through
each library call and put in exactly the includes the man page mentioned.

--
Peter Eisentraut Sernanders vaeg 10:115
peter_e(at)gmx(dot)net 75262 Uppsala
http://yi.org/peter-e/ Sweden