| From: | Kris Jurka <books(at)ejurka(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: GSS warnings |
| Date: | 2007-09-05 17:05:23 |
| Message-ID: | Pine.BSO.4.64.0709051258580.30413@leary.csoft.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
On Wed, 5 Sep 2007, Tom Lane wrote:
> Kris Jurka <books(at)ejurka(dot)com> writes:
>> Parts of the GSS API want the object while others want pointers to the
>> object and it looks like this code got it backwards. I haven't tested
>> these changes, but they look right to me.
>
> Wouldn't the code fail entirely if it was wrong in that way?
>
Only if it was ever run. My suspicion is that Port->gss->ctx/cred are
never set to anything other than GSS_C_NO_CONTEXT and GSS_C_NO_CREDENTIAL.
This patch also clarifies the checking we're doing on cleanup to be
more clear about whether these are pointers or not.
Kris Jurka
| Attachment | Content-Type | Size |
|---|---|---|
| gss-warn-2.patch | text/plain | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Teodor Sigaev | 2007-09-05 17:13:45 | Re: tsearch refactorings |
| Previous Message | Tom Lane | 2007-09-05 16:56:03 | Re: Lazy xid assignment V4 |