| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Kris Jurka <books(at)ejurka(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: GSS warnings |
| Date: | 2007-09-14 15:58:05 |
| Message-ID: | 200709141558.l8EFw5I29509@momjian.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Patch applied. Thanks.
---------------------------------------------------------------------------
Kris Jurka wrote:
>
>
> On Wed, 5 Sep 2007, Tom Lane wrote:
>
> > Kris Jurka <books(at)ejurka(dot)com> writes:
> >> Parts of the GSS API want the object while others want pointers to the
> >> object and it looks like this code got it backwards. I haven't tested
> >> these changes, but they look right to me.
> >
> > Wouldn't the code fail entirely if it was wrong in that way?
> >
>
> Only if it was ever run. My suspicion is that Port->gss->ctx/cred are
> never set to anything other than GSS_C_NO_CONTEXT and GSS_C_NO_CREDENTIAL.
> This patch also clarifies the checking we're doing on cleanup to be
> more clear about whether these are pointers or not.
>
> Kris Jurka
Content-Description:
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2007-09-14 16:25:54 | Re: invalidly encoded strings |
| Previous Message | Andrew Dunstan | 2007-09-14 15:55:58 | adjust chr()/ascii() to prevent invalidly encoded data |