From: | Kris Jurka <books(at)ejurka(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql-server: Fix TAS assembly stuff for Solaris/386. |
Date: | 2004-09-24 10:02:36 |
Message-ID: | Pine.BSO.4.56.0409240448010.27660@leary.csoft.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On Fri, 24 Sep 2004, Tom Lane wrote:
> > UINT64CONST produces these in a number of places:
> > "xlog.c", line 552: warning: constant promoted to unsigned long long
>
> This is pretty annoying, considering that the entire point of the
> UINT64CONST macro is to suppress such complaints. Can you suggest an
> incantation that will shut this compiler up?
it likes either ##ULL or unadorned. The problem is we're taking a
constant larger than long long and explicitly saying it's a long long.
> > Then there are a whole lot of code reachability warnings in these classes
> > - statement not reached
> > - end-of-loop code not reached
> > - loop not entered at top
>
> I think most of these come from flex and/or bison code that we don't
> have a lot of control over.
>
Another significant amount is from switch statements written like this:
switch(i) {
case 1:
return 1;
break;
}
Kris Jurka
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2004-09-24 14:05:54 | Re: pgsql-server: Fix TAS assembly stuff for Solaris/386. |
Previous Message | Neil Conway | 2004-09-24 09:58:11 | Re: pginstaller - CVSROOT: Update address for CVS |