From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Kris Jurka <books(at)ejurka(dot)com> |
Cc: | pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql-server: Fix TAS assembly stuff for Solaris/386. |
Date: | 2004-09-24 14:05:54 |
Message-ID: | 21218.1096034754@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Kris Jurka <books(at)ejurka(dot)com> writes:
> UINT64CONST produces these in a number of places:
> "xlog.c", line 552: warning: constant promoted to unsigned long long
> it likes either ##ULL or unadorned. The problem is we're taking a
> constant larger than long long and explicitly saying it's a long long.
No other machine we use thinks it's larger than long long --- are you
sure about that? If that is the problem, why does the message use the
word "promoted" and not, say, "truncated"?
>> I think most of these come from flex and/or bison code that we don't
>> have a lot of control over.
> Another significant amount is from switch statements written like this:
> switch(i) {
> case 1:
> return 1;
> break;
> }
Yeah, there are some of those. Do you think it's worth cleaning up,
given that we can't do anything about the ones induced by flex/bison?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Marc G. Fournier | 2004-09-24 14:22:32 | Re: pginstaller - CVSROOT: Update address for CVS |
Previous Message | Kris Jurka | 2004-09-24 10:02:36 | Re: pgsql-server: Fix TAS assembly stuff for Solaris/386. |