RE: Use __attribute__((target(sse4.2))) for SSE42 CRC32C

From: "Devulapalli, Raghuveer" <raghuveer(dot)devulapalli(at)intel(dot)com>
To: "Devulapalli, Raghuveer" <raghuveer(dot)devulapalli(at)intel(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Shankaran, Akash" <akash(dot)shankaran(at)intel(dot)com>
Subject: RE: Use __attribute__((target(sse4.2))) for SSE42 CRC32C
Date: 2024-11-08 19:05:23
Message-ID: PH8PR11MB8286F5DB1E3B1DAD5927FFBEFB5D2@PH8PR11MB8286.namprd11.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

V3: With the suggested changes.

Raghuveer

> -----Original Message-----
> From: Devulapalli, Raghuveer <raghuveer(dot)devulapalli(at)intel(dot)com>
> Sent: Friday, November 8, 2024 10:43 AM
> To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
> Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org; Shankaran, Akash
> <akash(dot)shankaran(at)intel(dot)com>
> Subject: RE: Use __attribute__((target(sse4.2))) for SSE42 CRC32C
>
> > I believe we expect MSVC builds to use meson at this point, which is
> > probably why there's this extra check:
> >
> > if cc.get_id() == 'msvc'
> > cdata.set('USE_SSE42_CRC32C', false)
> > cdata.set('USE_SSE42_CRC32C_WITH_RUNTIME_CHECK', 1)
> > have_optimized_crc = true
> >
>
> Ah, I missed this. This makes sense.
>

Attachment Content-Type Size
v3-0001-Use-__attribute__-target-sse4.2-for-SSE42-CRC32C.patch application/octet-stream 11.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Wolfgang Walther 2024-11-08 19:08:06 Fix port/pg_iovec.h building extensions on x86_64-darwin
Previous Message Devulapalli, Raghuveer 2024-11-08 18:43:12 RE: Use __attribute__((target(sse4.2))) for SSE42 CRC32C