Fix port/pg_iovec.h building extensions on x86_64-darwin

From: Wolfgang Walther <walther(at)technowledgy(dot)de>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Fix port/pg_iovec.h building extensions on x86_64-darwin
Date: 2024-11-08 19:08:06
Message-ID: 16989737-1aa8-48fd-8dfe-b7ada06509ab@technowledgy.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

When building pg_cron [1] or pg_hll [2] for PG 17 on x86_64-darwin, we
encounter the following build failure in nixpkgs:

/nix/store/2clw9wg933c40f871d8iqbl909lg2yis-postgresql-17.0-dev/include/server/port/pg_iovec.h:71:12:
error: comparison of integers of different signs: 'ssize_t' (aka 'long')
and 'const size_t' (aka 'const unsigned long') [-Werror,-Wsign-compare]
if (part < iov[i].iov_len)
~~~~ ^ ~~~~~~~~~~~~~~
/nix/store/2clw9wg933c40f871d8iqbl909lg2yis-postgresql-17.0-dev/include/server/port/pg_iovec.h:110:12:
error: comparison of integers of different signs: 'ssize_t' (aka 'long')
and 'const size_t' (aka 'const unsigned long') [-Werror,-Wsign-compare]
if (part < iov[i].iov_len)
~~~~ ^ ~~~~~~~~~~~~~~
2 errors generated.

The attached patch fixes those.

Hopefully this can make it into the minor release next week.

Best,

Wolfgang

[1]: https://hydra.nixos.org/build/276421287/nixlog/1
[2]: https://hydra.nixos.org/build/276419879/nixlog/1

Attachment Content-Type Size
0001-Fix-build-on-x86_64-darwin.patch text/x-patch 2.4 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alena Rybakina 2024-11-08 19:23:42 Re: Vacuum statistics
Previous Message Devulapalli, Raghuveer 2024-11-08 19:05:23 RE: Use __attribute__((target(sse4.2))) for SSE42 CRC32C