RE: Use __attribute__((target(sse4.2))) for SSE42 CRC32C

Anymore feedback on this patch? Hoping this is a straightforward one.

Raghuveer

> -----Original Message-----
> From: Devulapalli, Raghuveer <raghuveer(dot)devulapalli(at)intel(dot)com>
> Sent: Friday, November 8, 2024 11:05 AM
> To: Devulapalli, Raghuveer <raghuveer(dot)devulapalli(at)intel(dot)com>; Nathan Bossart
> <nathandbossart(at)gmail(dot)com>
> Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org; Shankaran, Akash
> <akash(dot)shankaran(at)intel(dot)com>
> Subject: RE: Use __attribute__((target(sse4.2))) for SSE42 CRC32C
>
> V3: With the suggested changes.
>
> Raghuveer
>
> > -----Original Message-----
> > From: Devulapalli, Raghuveer <raghuveer(dot)devulapalli(at)intel(dot)com>
> > Sent: Friday, November 8, 2024 10:43 AM
> > To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
> > Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org; Shankaran, Akash
> > <akash(dot)shankaran(at)intel(dot)com>
> > Subject: RE: Use __attribute__((target(sse4.2))) for SSE42 CRC32C
> >
> > > I believe we expect MSVC builds to use meson at this point, which is
> > > probably why there's this extra check:
> > >
> > > if cc.get_id() == 'msvc'
> > > cdata.set('USE_SSE42_CRC32C', false)
> > > cdata.set('USE_SSE42_CRC32C_WITH_RUNTIME_CHECK', 1)
> > > have_optimized_crc = true
> > >
> >
> > Ah, I missed this. This makes sense.
> >