RE: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL

From: "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>
To: Önder Kalacı <onderkalaci(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL
Date: 2023-03-20 07:18:22
Message-ID: OSZPR01MB6310B8C55B6184B07958B0A9FD809@OSZPR01MB6310.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Mar 17, 2023 11:29 PM Önder Kalacı <onderkalaci(at)gmail(dot)com> wrote:
>
> Thanks for sharing. Fixed
>
>
> This time I was able to run all the tests with all the patches applied.
>
> Again, the generated column fix also has some minor differences
> per version. So, overall we have 6 patches with very minor
> differences :)

Thanks for updating the patches. It seems you forgot to attach the patches of
dropped columns for HEAD and pg15, I think they are the same as v2.

On HEAD, we can re-use clusters in other test cases, which can save some time.
(see fccaf259f22f4a)

In the patches for pg12 and pg11, I am not sure why not add the test at end of
the file 100_bugs.pl. I think it would be better to be consistent with other
versions.

The attached patches modify these two points. Besides, I made some minor
changes, ran pgindent and pgperltidy. These are patches for dropped columns,
because I think this would be submitted first, and we can discuss the fix for
generated columns later.

Regards,
Shi Yu

Attachment Content-Type Size
v4-pg12-0001-Ignore-dropped-columns-when-REPLICA-IDENTITY-FUL.patch application/octet-stream 3.9 KB
v4-pg13-pg14-0001-Ignore-dropped-columns-when-REPLICA-IDENTITY-FUL.patch application/octet-stream 3.7 KB
v4-pg15-0001-Ignore-dropped-columns-when-REPLICA-IDENTITY-FUL.patch application/octet-stream 3.6 KB
v4-HEAD-0001-Ignore-dropped-columns-when-REPLICA-IDENTITY-FULL.patch application/octet-stream 3.6 KB
v4-pg11-0001-Ignore-dropped-columns-when-REPLICA-IDENTITY-FUL.patch application/octet-stream 3.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-03-20 07:32:14 Re: Remove nonmeaningful prefixes in PgStat_* fields
Previous Message Richard Guo 2023-03-20 07:18:17 Re: Missing rules for queryjumblefuncs.{funcs,switch}.c for maintainer-clean