RE: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.

From: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: 'Shubham Khanna' <khannashubham1197(at)gmail(dot)com>
Cc: Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com>
Subject: RE: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.
Date: 2025-03-03 12:29:15
Message-ID: OSCPR01MB14966C184318EA5F21823F9DFF5C92@OSCPR01MB14966.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dear Shubham,

I did a quick check and have a comment in drop_publication().

```
+ /* For cleanup purposes */
+ dbinfos.dbinfo->made_publication = true;
+
```

Please do not modify randomly. Currently, made_publication is set to false when
the command fails. No need to set to true here - Please follow that. Also, please
do not remove comments within the if statement.

Best regards,
Hayato Kuroda
FUJITSU LIMITED

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sergey Dudoladov 2025-03-03 12:29:41 Re: Add connection active, idle time to pg_stat_activity
Previous Message Álvaro Herrera 2025-03-03 11:56:24 Re: pg_stat_statements and "IN" conditions