| From: | Shubham Khanna <khannashubham1197(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Subject: | Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility. |
| Date: | 2025-03-04 04:59:39 |
| Message-ID: | CAHv8RjL4mWy9LUu1Ufat4ojqbf5bZEFkPcxN1B0ASC5-w=qvaA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 3, 2025 at 5:59 PM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear Shubham,
>
> I did a quick check and have a comment in drop_publication().
>
> ```
> + /* For cleanup purposes */
> + dbinfos.dbinfo->made_publication = true;
> +
> ```
>
> Please do not modify randomly. Currently, made_publication is set to false when
> the command fails. No need to set to true here - Please follow that. Also, please
> do not remove comments within the if statement.
>
Fixed the suggested changes. The attached patch contains the required changes.
Thanks and regards,
Shubham Khanna.
| Attachment | Content-Type | Size |
|---|---|---|
| v12-0001-Support-for-dropping-all-publications-in-pg_crea.patch | application/octet-stream | 23.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2025-03-04 05:09:09 | Re: Improve CRC32C performance on SSE4.2 |
| Previous Message | Ashutosh Bapat | 2025-03-04 04:58:16 | Re: Statistics Import and Export: difference in statistics dumped |