| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | "ShlokKumar(dot)Kyal(at)fujitsu(dot)com" <ShlokKumar(dot)Kyal(at)fujitsu(dot)com>, 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Subject: | RE: Selectively invalidate caches in pgoutput module |
| Date: | 2025-03-10 10:59:50 |
| Message-ID: | OSCPR01MB14966B4602D103050DC91837DF5D62@OSCPR01MB14966.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear hackers,
I did a self-reviewing and updated a patch. PSA new version. What's new:
1. Fixed a bug which existing name can be specified by ALTER PUBLICATION RENAME.
A validation is added in RenamePublication().
Just in case, we want to discuss the case that the renaming publication has thousands
of tables. Before the patch, The ALTER PUBLICATION RENAME command just invalidates
a syscache, and registered callback would invalidate all of them.
With the patch, however, all relsync entries are invalidated within the command
so that the execution time can be longer. I feel this can be acceptable because
some codes have such a part; E.g., ATTACH/DETACH partition command invalidates
relaches of the children when the specified relation also has children - even
if it has thousands of leaves. (See d6f1e16). Also note that all other processes
like walsender can be faster by avoiding discarding entire caches.
how do you feel?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-Introduce-a-new-invalidation-message-to-invalidat.patch | application/octet-stream | 10.1 KB |
| v8-0002-Invalidate-Relcaches-while-ALTER-PUBLICATION-RENA.patch | application/octet-stream | 6.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shubham Khanna | 2025-03-10 11:01:02 | Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility. |
| Previous Message | Peter Eisentraut | 2025-03-10 10:56:00 | Re: SQL:2011 application time |