| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Michael Paquier' <michael(at)paquier(dot)xyz> |
| Cc: | 'Aleksander Alekseev' <aleksander(at)timescale(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: doc patch: clarify the naming rule for injection_points |
| Date: | 2025-04-21 12:10:51 |
| Message-ID: | OSCPR01MB14966A5B704EF304E57FC9D57F5B82@OSCPR01MB14966.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Michael,
> > I also feel just converting lower case is not good. The point seems to locate in
> > the end-of-transaction callback and it accepts invalidation messages. Based on
> the
> > fact, how about "inval-process-invalidation-messages"?
> > 0002 did simple replacements of these words.
>
> - INJECTION_POINT("heap_update-before-pin");
> + INJECTION_POINT("heap-update-before-pin");
>
> The former name is better IMO. heap_update() is the name of the
> function where the point is defined.
>
> - INJECTION_POINT("AtEOXact_Inval-with-transInvalInfo");
> + INJECTION_POINT("inval-process-invalidation-messages");
>
> This naming has been puzzling me, though, so a rename looks fit. I am
> not sure that this is the best name that matches with this code path,
> as this lacks a reference regarding the end of a transaction. Perhaps
> something like "end-transaction-process-inval" would be better?
Thanks for suggesting them. ISTM, you are correct. PSA updated version.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Doc-clarify-the-naming-rule-for-injection-points.patch | application/octet-stream | 986 bytes |
| v3-0002-Follow-naming-rules-for-injection-points.patch | application/octet-stream | 6.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2025-04-21 14:10:38 | Re: Regression test fails when 1) old PG is installed and 2) meson/ninja build is used |
| Previous Message | Hayato Kuroda (Fujitsu) | 2025-04-21 11:42:48 | RE: Regression test fails when 1) old PG is installed and 2) meson/ninja build is used |